Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024: Decrease debuginfo generated by -Cdebuginfo=1 #613

Closed
1 of 3 tasks
jyn514 opened this issue Apr 12, 2023 · 2 comments
Closed
1 of 3 tasks

2024: Decrease debuginfo generated by -Cdebuginfo=1 #613

jyn514 opened this issue Apr 12, 2023 · 2 comments
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@jyn514
Copy link
Member

jyn514 commented Apr 12, 2023

Proposal

In the 2024 edition, change -C debuginfo=1 from being an alias for -C debuginfo=limited to an alias for -C debuginfo=line-tables-only.

For a long time, the available debuginfo options have been debuginfo=0, 1, or 2. The documentation said that 0 meant no debuginfo, 1 meant line tables, and 2 meant full debuginfo. Unfortunately that wasn't quite true - debuginfo=1 also generated full debuginfo for the module as well as line tables, which in some cases (e.g. rust-lang/rust#104968 (comment)) more than doubled the size of the debuginfo.

Due to backwards compat concerns, I added a new option, -C debuginfo=line-tables-only to decrease the debuginfo further, rather than changing the meaning of the existing flag (rust-lang/rust#109808, rust-lang/cargo#11958). I think this is in nearly all cases the intended meaning of the flag. I would like to make -C debuginfo=1 mean debuginfo=line-tables-only in the 2024 edition, which both gives people plenty of time to hear about the change and means that it's opt-in rather than breaking.

Mentors or Reviewers

I'm happy to mentor this work myself, the code itself should be fairly simple.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@jyn514 jyn514 added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Apr 12, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 12, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Apr 12, 2023
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 13, 2023
@apiraino
Copy link
Contributor

Closing MCP as not accepted

@apiraino apiraino closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

3 participants