Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed optional dependencies get the wrong feature name recorded #1175

Closed
Nemo157 opened this issue Nov 11, 2020 · 4 comments
Closed

Renamed optional dependencies get the wrong feature name recorded #1175

Nemo157 opened this issue Nov 11, 2020 · 4 comments
Labels
A-builds Area: Building the documentation for a crate C-bug Category: This is a bug

Comments

@Nemo157
Copy link
Member

Nemo157 commented Nov 11, 2020

async-compression 0.3.6 has a tokio-02 and a tokio-03 optional dependency, but these both get recorded and displayed as tokio. Dumping out of the database I see:

{
  ...
  "(all-implementations,\"{futures-io,stream,tokio-02,tokio-03}\")",
  ...
  "(tokio,{})",
  "(tokio,{})",
  ...
}

So all-implementations depends on tokio-02 and tokio-03, but the optional dependencies themselves show tokio.

.map(|dep| Feature::new(dep.name.clone(), Vec::new()))

Here it needs to take the renamed name (but unfortunately our little cargo-metadata dataset doesn't record this currently).

@almusil
Copy link
Contributor

almusil commented Nov 11, 2020

Since we need the rename, it would be also wise to extend the Feature in database with optional dependency indicator. It will be easier that way to filter etc IMO. WDYT?

@jyn514
Copy link
Member

jyn514 commented Nov 11, 2020

Sure, if you want to do both at once I'd be fine with that.

@jyn514 jyn514 added A-builds Area: Building the documentation for a crate C-bug Category: This is a bug labels Nov 11, 2020
@jyn514
Copy link
Member

jyn514 commented Dec 27, 2020

Fixed by #1180 I think.

@jyn514 jyn514 closed this as completed Dec 27, 2020
@Nemo157
Copy link
Member Author

Nemo157 commented Dec 27, 2020

Yep, https://docs.rs/crate/async-compression/0.3.7/features shows tokio-02 and tokio-03 headings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-builds Area: Building the documentation for a crate C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

3 participants