Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust logo is missing in interface, but it exists and returns (2020-03-23) #1328

Closed
syphar opened this issue Mar 23, 2021 · 4 comments · Fixed by #1330
Closed

rust logo is missing in interface, but it exists and returns (2020-03-23) #1328

syphar opened this issue Mar 23, 2021 · 4 comments · Fixed by #1330

Comments

@syphar
Copy link
Member

syphar commented Mar 23, 2021

grafik

grafik

For example (randomly chosen from the recent builds) here.

The really interesting thing is: **The 404 response actually returns the image, only sets the status-code to 404. ** :) (my mistake, early morning confusion)

A short local build was fine, so I'm not sure where the problem is.

@Nemo157
Copy link
Member

Nemo157 commented Mar 23, 2021

I don't see an image returned, for https://docs.rs/rust-logo-20210322-1.53.0-nightly-5d04957a4.png I get an HTML response "no crate found".

Seems likely to be related to #1324, it's not falling back from the rustdoc_redirect_handler to the rustdoc-shared-file handler correctly for .png.

@syphar
Copy link
Member Author

syphar commented Mar 23, 2021

I don't see an image returned, for https://docs.rs/rust-logo-20210322-1.53.0-nightly-5d04957a4.png I get an HTML response "no crate found".

my mistake, I was seeing the logo in the preview in the dev-tools, and assumed it is only the logo, while it's the whole 404 page 😆

@syphar
Copy link
Member Author

syphar commented Mar 23, 2021

I had a short look and could not reproduce it locally (with fresh crate builds on the same nightly, but only with the small local db I have).

Not sure if the file just wasn't copied at night.

@syphar
Copy link
Member Author

syphar commented Mar 23, 2021

at some point I need to find out why I could not reproduce this locally :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants