-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable compilation of miniz-sys on WASI #194
Conversation
Hmm, what did I do wrong? |
I believe stable doesnt support wasi yet. |
Switched to nightly, but still the same issue:
|
The target was renamed to |
Oh wow. That looks unusual / inconsistent with other target names (at least it's not a triple anymore). Why was it changed? |
|
This aligns build script conditions with all the `#[cfg(...)]` conditions in that miniz-sys shouldn't be attempted to be compiled on WASI target. In particular, this previously caused library to fail to compile to wasm32-wasi target from a Windows host.
@alexcrichton Should be ready now! @bjorn3 thanks for the help! |
@alexcrichton Could you please make a release when you have time? |
@RReverser I can point wasi-rustc to git until a release has been made. I did the same for |
@bjorn3 Yeah sure, I know about that workaround, just asked to make sure this is released at some near point in the future :) |
This aligns build script conditions with all the
#[cfg(...)]
conditions in that miniz-sys shouldn't be attempted to be compiled on WASI target.In particular, this previously caused library to fail to compile to wasm32-unknown-wasi target from a Windows host.