Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3 preview renaming #1099

Closed
MajorBreakfast opened this issue Jul 19, 2018 · 2 comments
Closed

0.3 preview renaming #1099

MajorBreakfast opened this issue Jul 19, 2018 · 2 comments

Comments

@MajorBreakfast
Copy link
Contributor

  • Cargo.toml (7 files)
    • package.name
    • package.documentation
    • dependencies
  • lib.rs (7 files)
    • #![doc(html_root_url = "...")]
  • Code examples:
    • All use statements should refer to the preview crates

Question: Why do the extern crate statements in the current master branch (0.2) never use as, e.g. extern crate futures-preview as futures;? It seems to work, but I don't quite understand how it finds the crates if their actual name is different.

@Nemo157
Copy link
Member

Nemo157 commented Jul 19, 2018

As @withoutboats recently mentioned on the 2018 stabilisation thread having rust-lang/cargo#5653 would be amazing for this. You could use and recommend futures = { package = "futures-preview", version = "0.3.0-alpha.1" } as the way to depend on the preview. Unfortunately there’s been no confirmation one way or the other whether this cargo feature could be stabilised for the first 2018 release.

@MajorBreakfast
Copy link
Contributor Author

MajorBreakfast commented Jul 19, 2018

Implemented by #1103

Renaming of the use statements was not required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants