-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AsyncSeek trait #1512
Comments
@yoshuawuyts do you know if there are actual async implementations of seeking available anywhere? I assume the FS API for Romio would just be doing something like a blocking seek on a thread-pool? I guess it still makes sense to add the trait as an operation that code will want to use, even if there aren't any implementations that can cheaply support it yet. |
Yeah, that's our thinking for Romio currently. Ideally we could later investigate using AIO / io_uring to have true async fs calls, but until then having the trait available would be nice for all implementations (: |
Just gonna leave this here, we have a PR open in tokio for sometime around this, may be useful tokio-rs/tokio#785 |
Thanks so much @taiki-e! 🎉 |
Yeah-- huge thanks @taiki-e! All of your recent work on futures-rs has been incredibly helpful <3 |
I've def been missing an
AsyncSeek
impl. We've been looking to implement a filesystem API for Romio, and that's one of the traits we need. Tokio has a counterpart directly implemented on the File struct, but it seems being able to generalize it would be ideal.Originally posted by @yoshuawuyts in #1510 (comment)
The text was updated successfully, but these errors were encountered: