Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Some GitHub API requests fail with 404 #190

Open
pietroalbini opened this issue Jan 26, 2019 · 1 comment
Open

Some GitHub API requests fail with 404 #190

pietroalbini opened this issue Jan 26, 2019 · 1 comment
Labels

Comments

@pietroalbini
Copy link
Member

Sometimes the GitHub API returns a 404 while trying to fetch the PR's diff, right after the webhook is received. Retrying those requests later return the correct data. This is probably some eventual consistency on the GitHub side.

We should retry that request after 1 second if it fails with a 404, to prevent highfive crashing.

@dwijnand
Copy link
Member

dwijnand commented Mar 2, 2019

Perhaps this is why sometimes highfive doesn't assign anyone to PRs in the cargo repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants