Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

rust-highfive only warns about updated submodules when a PR is created #223

Closed
varkor opened this issue Jul 1, 2019 · 4 comments
Closed

Comments

@varkor
Copy link
Member

varkor commented Jul 1, 2019

Or maybe it also warns when a new commit is pushed, but definitely not when commits are force pushed (as seen in rust-lang/rust#62235).

@jyn514
Copy link
Member

jyn514 commented May 24, 2021

Looking at app.py, it seems like highfive only ever runs on new PRs, never changes. Someone will need to add the ability to look at changes to highfive (or more likely, rewrite the whole thing into triagebot). @Mark-Simulacrum do you have opinions on which is the right approach?

@RalfJung
Copy link
Member

The issue also applies to pinging teams when a PR touches code in their responsibility.

@ehuss
Copy link
Contributor

ehuss commented Jun 27, 2022

I have opened a PR at rust-lang/triagebot#1625 which aims to solve this issue (and moves "mentions" to triagebot).

@ehuss
Copy link
Contributor

ehuss commented Jun 28, 2022

This should now essentially be fixed in triagebot, so I think this could probably be closed.

@jyn514 jyn514 closed this as completed Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants