Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bors ignore mentions in inline code blocks. #170

Open
xFrednet opened this issue May 8, 2022 · 0 comments
Open

Make bors ignore mentions in inline code blocks. #170

xFrednet opened this issue May 8, 2022 · 0 comments

Comments

@xFrednet
Copy link
Member

xFrednet commented May 8, 2022

Hey, often with delegates you want to let the user know how they can r+ and that they should use r=<name> to approve the PR. An example comment often looks like this:

I'll let you handle the r+ so you don't need to ping me again when CI pass. Please use @bors r=<name> once it's green.

@bors delegate=xFrednet

Example taken from: rust-lang/rust#95542

However, bors seams to only see the r=<name> and approves this while ignoring the delegate command. It would be nice to either ignore mentions in inline code all together or, as a quick workaround, first check for a delegate and if not present approve the PR 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant