-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bors squash does not close PRs #181
Comments
I think the only way to fix this is to have bors force-push the squased commit to the PR's branch |
Partial copypaste from #182: |
I'm not sure to understand the problem. Do you mean that the "fix verbatim with upstream dependencies" commit should not belong to bors ? If that's what you mean, then it's #136. Is there still another way it behaves unexpectedly ? |
See rust-lang/miri#2541: a PR merged with bors squashing does not get closed.
The text was updated successfully, but these errors were encountered: