Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bors squash does not close PRs #181

Open
RalfJung opened this issue Sep 14, 2022 · 3 comments
Open

bors squash does not close PRs #181

RalfJung opened this issue Sep 14, 2022 · 3 comments

Comments

@RalfJung
Copy link
Member

See rust-lang/miri#2541: a PR merged with bors squashing does not get closed.

@kellda
Copy link
Contributor

kellda commented Sep 14, 2022

I think the only way to fix this is to have bors force-push the squased commit to the PR's branch

@klensy
Copy link
Contributor

klensy commented Sep 20, 2022

Partial copypaste from #182:
This also left stray commit in bors gh history, and if noone wants to fix that squash for now, it better be disabled (that change should be easy?).

@kellda
Copy link
Contributor

kellda commented Sep 20, 2022

I'm not sure to understand the problem. Do you mean that the "fix verbatim with upstream dependencies" commit should not belong to bors ? If that's what you mean, then it's #136. Is there still another way it behaves unexpectedly ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants