Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move off rust-lang-ci #188

Open
8 tasks
Kobzol opened this issue Dec 19, 2024 · 4 comments
Open
8 tasks

Move off rust-lang-ci #188

Kobzol opened this issue Dec 19, 2024 · 4 comments

Comments

@Kobzol
Copy link

Kobzol commented Dec 19, 2024

We would like to get rid of the rust-lang-ci organization, which should no longer be needed:

  • We can now configure secrets on GH per branch, so we can configure secrets only for the auto and try branches, not for all CI.
  • We get 500 concurrent jobs across all repos in the rust-lang organization, so that should be enough to run all CI in a single org.
  • We no longer use self-hosted runners.

The following (probably non-exhaustive) list below tracks what needs to be done to get rid of rust-lang-ci:

This idea was discussed on Zulip.

@jdno jdno added this to infra-team Dec 20, 2024
@github-project-automation github-project-automation bot moved this to Backlog in infra-team Dec 20, 2024
@jdno jdno moved this from Backlog to Ready in infra-team Dec 20, 2024
@pietroalbini
Copy link
Member

A missing thing is that rustup also refers to the docker images built by rust-lang/rust's CI.

@Kobzol
Copy link
Author

Kobzol commented Jan 12, 2025

That's the same thing as Switch CI to use Docker ghcr.io caches from the rust-lang organization; rust's CI writes the image tag into a file stored at S3, and rustup downloads it. Whatever is written by Rust's CI into that file will determine from where rustup downloads the Docker images (be it rust-lang or rust-lang-ci's ghcr.io hub).

@Mark-Simulacrum
Copy link
Member

Just to check, even if we did use self-hosted runners I think those are also fine in a single org now (GitHub upstream made changes for that), right?

@pietroalbini
Copy link
Member

Just to check, even if we did use self-hosted runners I think those are also fine in a single org now (GitHub upstream made changes for that), right?

Yes. If the runners are placed in a runner group, it's possible to restrict which workflows can access them. We could then restrict them to rust-lang/rust/.github/workflows/ci.yml@auto to only allow them to execute ci.yml on the auto branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

3 participants