Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfnetlink constants #1562

Closed
vorner opened this issue Oct 18, 2019 · 3 comments
Closed

nfnetlink constants #1562

vorner opened this issue Oct 18, 2019 · 3 comments

Comments

@vorner
Copy link
Contributor

vorner commented Oct 18, 2019

Hello

I'd like to ask, would it be OK to add netfilter netlink constants. They are in the linux headers (/usr/include/linux/netfilter/nfnetlink*.h). I'm trying to extend neli with nfnetlink support (currently NFLOG, jbaublitz/neli#48).

I'll send a pull request, I just wanted to ask first if including these would be OK.

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 20, 2019

Sure.

@JohnTitor
Copy link
Member

I assume this is done by #1628 and am going to close but feel free to re-open if I'm missing something.

@vorner
Copy link
Contributor Author

vorner commented Oct 15, 2020

I think there are some few more constants in the header, but I guess a lazy approach (once they are actually needed) is good and there's not much use for keeping this issue open :-). Sorry for letting it rot in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants