Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider re-structuring linux-like stuff #1915

Open
JohnTitor opened this issue Oct 7, 2020 · 3 comments
Open

Consider re-structuring linux-like stuff #1915

JohnTitor opened this issue Oct 7, 2020 · 3 comments
Labels
E-medium E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. I-needs-decision O-android O-linux O-linux-like
Milestone

Comments

@JohnTitor
Copy link
Member

As mentioned in #1913 (comment), we could consider re-structuring linux-like stuff, i.e., Android and emscripten so that we could de-duplicate some items and remove make it more consistent.

@joshtriplett
Copy link
Member

In particular, we could move android under linux rather than just linux_like (since it actually runs Linux and should have most things in common), and we could also move emscripten up from linux_like to unix if that wouldn't create too much duplication.

If we do both, we'd stop needing the linux_like level at all. If we do just one or the other, I'd say it should be to move android under linux.

@skrap
Copy link
Contributor

skrap commented Nov 9, 2020

Not directly related, but I am working with uclibc, and considering whether to put together a PR to move uclibc under linux-like/linux, which is where I felt it belonged anyway. Reading the git history, it seems unclear to me why it was kept out of what was then not-bsd. This probably isn't the correct forum to ask, but would a PR to move uclibc be considered?
If this isn't an ok spot to ask, then my apologies! Please feel free to point me at a better spot.

@workingjubilee
Copy link
Member

I think that moving uclibc around would be fine, if it's not been moved already (the question was asked over 2 years ago...).

I think that Emscripten should definitely be moved out of "Linux-like", or whatever other refactoring. It definitely tries to pare everything down to the narrow edge of "POSIX-only", which means common Linux extensions, even ones implemented by multiple other BSD OS, because they're actually part of fundamental things like ELF, don't fly on it. Thus it is creating more code duplication to have things duplicated between Linux-and-Android-but-not-Emscripten. I also notice a lot of PRs to add stuff to the libc API surface for the Linuxes tend to fail on Emscripten, specifically.

@tgross35 tgross35 added the E-medium E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. label Aug 29, 2024
@tgross35 tgross35 added this to the 1.0 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-medium E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. I-needs-decision O-android O-linux O-linux-like
Projects
None yet
Development

No branches or pull requests

5 participants