Lower the MSRV to 1.63 #3881
Merged
Lower the MSRV to 1.63 #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
tgross35
force-pushed
the
msrv-1.63
branch
3 times, most recently
from
e80cb39
to
a24c079
Compare
Since this is packed [1] and we don't have `Copy`, we won't need the extra traits. Remove them here, which also helps lower the MSRV. Additionally, remove some implementations on a union and packed structs that could be unaligned. [1]: https://opensource.apple.com/source/xnu/xnu-7195.81.3/bsd/net/if.h.auto.html
This will get us compatibility with Debian stable. If this turns out to be problematic, we can always raise it back in the time before 1.0 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will get us compatibility with Debian stable.
If this turns out to be problematic, we can always raise it back in the time before 1.0 is released.