Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AT_EACCESS to emscripten #3911

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Add AT_EACCESS to emscripten #3911

merged 1 commit into from
Sep 25, 2024

Conversation

ChanTsune
Copy link
Contributor

Header source:
AT_EACCESS

@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@tgross35
Copy link
Contributor

Easy enough, could you update libc-test/semver/emscripten.txt?

tgross35
tgross35 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Sep 25, 2024
@ChanTsune
Copy link
Contributor Author

Thank you for review!
I added it.

@rustbot review

auto-merge was automatically disabled September 25, 2024 00:41

Head branch was pushed to by a user without write access

@tgross35 tgross35 added this pull request to the merge queue Sep 25, 2024
Merged via the queue into rust-lang:main with commit b23f517 Sep 25, 2024
41 checks passed
@ChanTsune ChanTsune deleted the emscripten-AT_EACCESS branch September 25, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 Awaiting requested review from tgross35

Assignees

@tgross35 tgross35

Labels
S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChanTsune @rustbot @tgross35