Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unstable Poll::ready #214

Closed
ibraheemdev opened this issue Apr 21, 2023 · 1 comment
Closed

Remove unstable Poll::ready #214

ibraheemdev opened this issue Apr 21, 2023 · 1 comment
Labels
ACP-accepted API Change Proposal is accepted (seconded with no objections) api-change-proposal A proposal to add or alter unstable APIs in the standard libraries T-libs-api

Comments

@ibraheemdev
Copy link
Member

Proposal

Poll::ready was added as an experimental alternative to task::ready!, but was deemed to problematic because of the already existing Try implementations for Poll (see rust-lang/rust#89780 for the relevant discussion). Fixing this would likely require changes over an edition, which seems unlikely after task::ready! was already stabilized, so I think we should just go ahead and remove Poll::ready.

Pull request: rust-lang/rust#107060
@ibraheemdev ibraheemdev added api-change-proposal A proposal to add or alter unstable APIs in the standard libraries T-libs-api labels Apr 21, 2023
@ibraheemdev ibraheemdev changed the title (My API Change Proposal) Remove unstable Poll::ready Apr 21, 2023
@Dylan-DPC Dylan-DPC mentioned this issue May 18, 2023
Merged
@m-ou-se m-ou-se added the ACP-accepted API Change Proposal is accepted (seconded with no objections) label May 19, 2023
@m-ou-se
Copy link
Member

m-ou-se commented May 19, 2023

As discussed in the libs meetup: we can proceed with rust-lang/rust#107060 to remove the unstable .ready() method, as ready!() is already stable. Thanks!

@m-ou-se m-ou-se closed this as completed May 19, 2023
bors added a commit to rust-lang-ci/rust that referenced this issue May 19, 2023
@bors
Auto merge of rust-lang#107060 - ibraheemdev:poll-ready, r=joshtriplett
8a281f9 
Remove unstable `Poll::ready`

Based on the discussion in rust-lang#89780, this API is problematic and would likely require changes over an edition. Now that `task::ready!` is stabilized, this seems unlikely to happen, so I think we should just go ahead and remove it.

ACP: rust-lang/libs-team#214
@dtolnay dtolnay mentioned this issue Apr 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ACP-accepted API Change Proposal is accepted (seconded with no objections) api-change-proposal A proposal to add or alter unstable APIs in the standard libraries T-libs-api
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m-ou-se @ibraheemdev