Merge pull request #73 from TimNN/mingw-no-export-4.0

[JSBackend] don't use dllexport since it causes problems when building rustc
rust-lang · Jun 27, 2017 · b6b4e81 · b6b4e81
2 parents 8c8ecd9 + a62cd42
commit b6b4e81
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/Target/JSBackend/Relooper.h b/lib/Target/JSBackend/Relooper.h
@@ -344,7 +344,12 @@ struct Debugging {
 
 // C API - useful for binding to other languages
 
-#ifdef _WIN32
+// #ifdef _WIN32
+// Any item marked as dllexport causes the mingw linker to no longer export
+// unmarked symbols, which causes build problems for rustc (since the symbols it
+// needs are no longer exported), so make sure all symbols are unmarked.
+// See: https://github.com/rust-lang/rust/pull/40123#issuecomment-293798939
+#if 0
   #ifdef RELOOPERDLL_EXPORTS
     #define RELOOPERDLL_API __declspec(dllexport)
   #else