-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Statement Breaks when Given Path with Certain Special Characters #1098
Comments
I think I see what's going on with the colons. The logic for parsing includes takes the first colon and interprets it as a separator between the actual path and a range/anchor thingy. I'll dig into what's up with pluses eventually. It feels like without changing range/anchor syntax and breaking backwards compatibility, a way to fix this is to introduce an escape character for colons that are part of the path. Or maybe the path can be optionally wrapped in double quotes? I like that more. |
I finally (sorry) took a look. It looks like the plus is a different beast - the Fixing this one is trivial. It seems to work fine after adding I'd be happy to make a pull request once we know how we want to handle colons! |
I would kinda prefer not to support colons in the path (and not deal with absolute Windows paths, or deal with an escaping system), but fixing other characters like |
#1098 Links preprocessor: support pluses
Thanks for the work on this issue! I can confirm that the fix for the plus works. |
…t-pluses rust-lang#1098 Links preprocessor: support pluses
The
#include
statement breaks when it is given a path with certain special characters.Here an example. The following source:
Results in:
The text was updated successfully, but these errors were encountered: