Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #1135 #1180

Closed
XAMPPRocky opened this issue Apr 3, 2020 · 2 comments · Fixed by #1181
Closed

Revert #1135 #1180

XAMPPRocky opened this issue Apr 3, 2020 · 2 comments · Fixed by #1181

Comments

@XAMPPRocky
Copy link
Member

XAMPPRocky commented Apr 3, 2020

Hey, I upgraded my mdbook and my project stopped building when using mdbook-0.3.6 because of #1135. I'm fairly sure its behaviour is incorrect and should be reverted. For some context, in rust-lang teams and projects groups have a meta repository for team coordination (e.g. rust-lang/lang-team). Some of us also started trying to have this information available through mdbook. As it can be a nicer interface at times especially since it shows a complete tree of contents that you control where as GitHub does not. These repositories are entirely markdown files and doesn't really make sense to have every folder be a subfolder in the src directory.

You can see in the gh-pages branch of rust-lang/project-group-template it doesn't generate recursive copies of itself, it generates a normal mdbook project. To me this is a legitimate behaviour that should be allowed.

@ehuss
Copy link
Contributor

ehuss commented Apr 3, 2020

Sorry, I'm a bit confused. Is it just not working correctly, or is it giving an error message? It might be helpful to provide a reproduction, and an explanation of what isn't behaving as expected. From the given links, I see a template of a book with 4 chapters, and I don't see anything particularly wrong with it.

@XAMPPRocky
Copy link
Member Author

XAMPPRocky commented Apr 3, 2020

@ehuss Sorry, I wrote this late and forgot to include the logs. The project fails to build with Destination directory cannot be contained in source directory error. https://github.com/rust-lang/project-group-template/runs/556822171#step:3:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants