-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usages of the <base> tag causes confusion #279
Comments
Anyone have opinions about removing |
So I am not opposed to remove it, but then maybe we would need to process internal links during the build phase to make them start from the root? |
At Rust Cookbook, while trying to implement link checkers in the CI, we were hard pressed to find one that accepted https://validator.w3.org/checklink?uri=https%3A%2F%2Fdoc.rust-lang.org%2Fstable%2Frust-by-example%2Fhello%2Fprint.html&hide_type=all&depth=&check=Check demonstrates some of the output we were seeing. Currently, @budziq is writing a link checker that accepts base href='../' as valid, but it is my thinking that if w3 validators are failing, it might be malformed. |
I believe this should be resolved by #603. We're planning to migrate away from the |
@Michael-F-Bryan I was planning on testing #603 against the cookbook this weekend but ran into all kinds of technical issues. I suspected it would resolve my issues, and I'm thankful you clarified that for me. |
This is now fixed by #603 and should be closed. |
Thought I'd document a painpoint we encountered: rust-lang/rust#41476 (comment)
The text was updated successfully, but these errors were encountered: