Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional CSS Should create directories #585

Closed
Havvy opened this issue Jan 26, 2018 · 4 comments · Fixed by #586
Closed

Additional CSS Should create directories #585

Havvy opened this issue Jan 26, 2018 · 4 comments · Fixed by #586

Comments

@Havvy
Copy link
Contributor

Havvy commented Jan 26, 2018

This seems to be a regression from 0.0.28, but when I put in the config that additional-css = ["theme/reference.css"], it complains:

[havvy@ref:~/workspace/rust/reference]$ ~/.cargo/bin/mdbook build
2018-01-25 20:21:28 [INFO] (mdbook::book): Book building has started
2018-01-25 20:21:28 [INFO] (mdbook::book): Running the html backend
2018-01-25 20:21:28 [ERROR] (mdbook::utils): Error: Rendering failed
2018-01-25 20:21:28 [ERROR] (mdbook::utils):    Caused By: Unable to copy across additional CSS and JS
2018-01-25 20:21:28 [ERROR] (mdbook::utils):    Caused By: Unable to copy theme/reference.css to /home/havvy/workspace/rust/reference/book/theme/reference.css
2018-01-25 20:21:28 [ERROR] (mdbook::utils):    Caused By: No such file or directory (os error 2)

I would expect mdbook to actually make the theme directory specified and then put reference.css into it.

@steveklabnik
Copy link
Member

@Michael-F-Bryan is there a way we could get a point release with this change in it?

@Michael-F-Bryan
Copy link
Contributor

Sure thing, I'll make another release when #590 is merged.

@Michael-F-Bryan
Copy link
Contributor

Michael-F-Bryan commented Jan 27, 2018

@steveklabnik done!

@steveklabnik
Copy link
Member

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants