-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support anchors in SUMMARY #1173
Conversation
@Dylan-DPC I think it would be good to have some discussion before merging big changes like this. Some issues:
|
Don't hesitate to revert this if it causes any issue, however:
It shouldn't break any existing book though, because files with anchors are completely broken now.
This is incorrect: it always focuses the main section, eg. for my book it will display as even if you click on the |
@ehuss ah my bad didnt see the issue. |
This reverts commit 2baed04.
reverted in #1175 |
This reverts commit ce09c93.
* Parse anchors in `SUMMARY.md` * Support sub-links in SUMMARY with html renderer * Add some tests for anchors
This reverts commit ce09c93.
While porting a book of mine from GitBook to mdBook, I noticed that anchors are not supported in the SUMMARY file:
For example, given the following summary:
The following wrong things are going to happen when running
mdbook build
:doc/Foo#anchor-1.md
anddoc/Foo#anchor-2.md
are going to be created.Foo
section point toFoo.html
, which is empty.