Consistently use io error handlers #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saethlin
reviewed
Oct 25, 2024
| if let Some(entry) = open_dir.entry { | ||
| this.deallocate_ptr(entry, None, MiriMemoryKind::Runtime.into())?; | ||
| } | ||
| drop(open_dir); |
There was a problem hiding this comment.
Is this drop actually doing anything? It'll be dropped anyway at the upcoming close brace, right?
Suggested change
| drop(open_dir); |
There was a problem hiding this comment.
It may be intended to clarify that we own open_dir here... but it doesn't really achieve that to be fair.
saethlin
approved these changes
Oct 25, 2024
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the last, least obvious parts of #3930
Fixes #3930