Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change gather/scatter mask sizes to match data size not index/address size since that matches x86_64 #323

Open
programmerjake opened this issue Dec 14, 2022 · 0 comments
Open

change gather/scatter mask sizes to match data size not index/address size since that matches x86_64 #323

programmerjake opened this issue Dec 14, 2022 · 0 comments

Comments

@programmerjake
Copy link
Member

programmerjake commented Dec 14, 2022 •
edited
Loading

iirc x86_64 without avx512 is the only major isa that uses full-masks instead of bit-masks and has gather, so we should match it.
https://www.felixcloutier.com/x86/vgatherdps:vgatherqps#vgatherqps--vex-128-version-iirc
vgatherqps gathers f32 values using i32 mask elements and u64 indexes/addresses.

originally mentioned here:
#322 (comment)
@programmerjake programmerjake mentioned this issue Dec 14, 2022
Open
@programmerjake programmerjake changed the title change gather/scatter mask sizes to match data size not index/address size since that matches x86 change gather/scatter mask sizes to match data size not index/address size since that matches x86_64 Dec 14, 2022
@calebzulawski calebzulawski mentioned this issue Feb 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@programmerjake