Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-importing completions query unrelated bodies #14677

Closed
Veykril opened this issue Apr 28, 2023 · 1 comment · Fixed by #14715
Closed

Auto-importing completions query unrelated bodies #14677

Veykril opened this issue Apr 28, 2023 · 1 comment · Fixed by #14715
Labels
A-completion autocompletion A-perf performance issues C-bug Category: bug

Comments

@Veykril
Copy link
Member

Veykril commented Apr 28, 2023

In auto importing completions we use the crate_symbols query which runs module_symbols queries which then query for bodies of body definitions for collecting items defined inside of them. This is done for world symbols lookup, but these inner items are irrelevant to auto importing completions as there is no path that can be used to refer to them (except for inner items declared inside of the body we are completing in).

We should separate this somehow.

@Veykril Veykril added A-completion autocompletion A-perf performance issues C-bug Category: bug labels Apr 28, 2023
@Veykril
Copy link
Member Author

Veykril commented May 2, 2023

We apparently unconditionally parse files in module_symbols already for fetching the name ranges. That's also something we should try to avoid. Fixed in #14715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-completion autocompletion A-perf performance issues C-bug Category: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant