Limited feedback in large VS Code workspace

[djc]

I have a largish VS Code workspace; at the moment it contains 13 projects, each of these contains one crate or virtual workspace in the root. After starting VS Code, rust-analyzer reports "workspace loaded, 2268 rust packages", and there's no output in the debug console.

However, after loading this workspace, I only get very limited feedback from rust-analyzer. For example, if I change a field name to be incorrect, there's no error (as in, red underlining). However, syntax errors are correctly flagged (for example, if I remove the comma between two items in imports).

I'm using rust-analyzer master as my daily driver, updated every few days. Currently running 9d786ea.

[bjorn3]

For example, if I change a field name to be incorrect, there's no error (as in, red underlining).

That kind of errors comes from cargo watch I believe, not ra itself. Does cargo watch get run for all cargo workspaces/projects?

[djc]

I have "Enable Cargo Watch On Startup" set to true in the VS Code config, if that's what you're asking.

[bjorn3]

I was thinking about if the ra ext does actually run cargo watch for all projects of a vscode workspace.

[djc]

@matklad seems to suggest it should work in #1834 (comment).

[djc]

@matklad do you have any feedback on what might be going on here? Is there something else I could do to debug this? I'd be potentially down with hacking on this if there is a clear path to get it working again.

[matklad]

Haven't looked into this yet, but my understanding is that, while in theory we support multi-workspace setups, no plumbing has been done to actually enable this.

Hm, now that I actually look at the code, there's code that tries to handle this use-case

• https://github.com/rust-analyzer/rust-analyzer/blob/5c3ccc55082838524f695ffe40138fd8e805db70/crates/ra_lsp_server/src/main_loop.rs#L66
• https://github.com/rust-analyzer/rust-analyzer/blob/5c3ccc55082838524f695ffe40138fd8e805db70/crates/ra_lsp_server/src/main.rs#L43-L49

I am not sure if this code actually works (as you can guess from the fact that I don't even remmeber that this code exists :) ), as I am not using multi-workspace myself.

So, the thing to do here would be:

• add some printfs around that lines, to see if they actually work
• add a multi-workspace workspace test to heavy_tests.rs (semi-unrelated, but we should refactor heavy-tests such that there's only a single heavy test that check everything, because initint a heavy test is really slow).

[djc]

I've been setting up a new machine where I actually saw this working. My current hypothesis is that it'll fail if one of the workspaces has a compilation bug (or potentially a dependency conflict).

[djc]

@daern91 seems to be talking about a Cargo workspace, whereas I was talking about a VS Code workspace that contained many projects, where each project is its own Cargo workspace. Do you have reason to assume this works now? I moved away from working like that because of this bug.