Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our polyfill for __float128 should have 16 byte alignment #317

Closed
fitzgen opened this issue Dec 4, 2016 · 1 comment
Closed

Our polyfill for __float128 should have 16 byte alignment #317

fitzgen opened this issue Dec 4, 2016 · 1 comment
Labels

Comments

@fitzgen
Copy link
Member

fitzgen commented Dec 4, 2016

Right now it is an array of u8 and has 1 byte alignment, I think.

u128 and i128 just landed in rustc, and we should take advantage of them here until Rust has a proper f128 since they should have the alignment restrictions we need.

This will only be available on nightly / unstable for a bit I think.

@pvdrz
Copy link
Contributor

pvdrz commented Nov 17, 2022

This already happens. I wasn't able to bisect to get the right commit due to not being able to compile old versions of bindgen with the right rustc version

@pvdrz pvdrz closed this as completed Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants