Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use rust-cache@v2 when building on CI #13033

Open
blyxyas opened this issue Jul 3, 2024 · 4 comments
Open

[CI] Use rust-cache@v2 when building on CI #13033

blyxyas opened this issue Jul 3, 2024 · 4 comments
Labels
A-infra Area: CI issues and issues that require full access for GitHub/CI performance-project For issues and PRs related to the Clippy Performance Project

Comments

@blyxyas
Copy link
Member

blyxyas commented Jul 3, 2024

Description

We're currently only using cache on the lintcheck.yml workflow. This means that we're downloading and building the same crates a lot. We currently use about 50s on that Build step. About a third of the CI time.

We should use the rust-cache Action for this purpose.

Version

NA

Additional Labels

No response

@blyxyas blyxyas added A-infra Area: CI issues and issues that require full access for GitHub/CI performance-project For issues and PRs related to the Clippy Performance Project labels Jul 3, 2024
@BD103
Copy link
Contributor

BD103 commented Nov 26, 2024

Can I suggest Leafwing-Studios/cargo-cache for this purpose? It works the same as rust-cache, but also sweeps the target directory to remove stale artifacts that are not used.

Even if that's decided against, I'm still interested in working on this issue as a whole. Just give me a 👍 to get started :)

@blyxyas
Copy link
Member Author

blyxyas commented Nov 26, 2024

If you think that Leafwing-Studios/cargo-cache would fit better, feel free to use it! ❤

@blyxyas
Copy link
Member Author

blyxyas commented Nov 27, 2024

Btw, if you open a PR, remember to assign it to me by writing "r? @blyxyas" as the last line of the PR description.

@flip1995
Copy link
Member

flip1995 commented Dec 4, 2024

Please keep me in the loop with CI changes. I'm usually auto-assigned to PRs touching those files, if you don't add an explicit r?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infra Area: CI issues and issues that require full access for GitHub/CI performance-project For issues and PRs related to the Clippy Performance Project
Projects
None yet
Development

No branches or pull requests

3 participants