Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint usage of negative feature names in Cargo.toml #1746

Closed
kennytm opened this issue May 11, 2017 · 1 comment
Closed

Lint usage of negative feature names in Cargo.toml #1746

kennytm opened this issue May 11, 2017 · 1 comment
Labels
A-lint Area: New lints C-an-interesting-project Category: Interesting projects, that usually are more involved design/code wise. E-medium Call for participation: Medium difficulty level problem and requires some initial experience. S-needs-discussion Status: Needs further discussion before merging or work can be started T-cargo Type: cargo related

Comments

@kennytm
Copy link
Member

kennytm commented May 11, 2017

(Only works with cargo clippy, may not be in scope with clippy. See #1614)

Features are supposed to be additive, and negatively-named features violate it. Lint when the crate declares a feature named no_std / no-std, and suggest using default-features = ["std"] instead.

(Main motivation in rust-lang/rfcs#1841.)
@oli-obk oli-obk added C-an-interesting-project Category: Interesting projects, that usually are more involved design/code wise. S-needs-discussion Status: Needs further discussion before merging or work can be started E-medium Call for participation: Medium difficulty level problem and requires some initial experience. A-lint Area: New lints T-cargo Type: cargo related labels May 11, 2017
@clarfonthey
Copy link
Contributor

Perhaps we could also suggest common conventions, like nightly => unstable.

@camsteffen camsteffen mentioned this issue Aug 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: New lints C-an-interesting-project Category: Interesting projects, that usually are more involved design/code wise. E-medium Call for participation: Medium difficulty level problem and requires some initial experience. S-needs-discussion Status: Needs further discussion before merging or work can be started T-cargo Type: cargo related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kennytm @oli-obk @camsteffen @clarfonthey