Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal lint: check if span_lint_and_then and span_* are collapsable #5095

Closed
JohnTitor opened this issue Jan 25, 2020 · 1 comment · Fixed by #5141
Closed

Internal lint: check if span_lint_and_then and span_* are collapsable #5095

JohnTitor opened this issue Jan 25, 2020 · 1 comment · Fixed by #5141
Labels
A-lint Area: New lints good-first-issue These issues are a good way to get started with Clippy

Comments

@JohnTitor
Copy link
Member

When span_lint_and_then and span_* have the same span, we can replace them with span_lint_and_* in most cases. It'd be nice that we have an internal lint for this.
It's a follow-up for this comment.
@JohnTitor JohnTitor mentioned this issue Jan 25, 2020
Merged
@flip1995
Copy link
Member

Also only if the db.span_* is the only Expr/Stmt in the closure of span_lint_and_then.

@flip1995 flip1995 added good-first-issue These issues are a good way to get started with Clippy A-lint Area: New lints labels Jan 26, 2020
This was referenced Feb 1, 2020
Closed
Merged
@bors bors closed this as completed in 6dcc8d5 Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: New lints good-first-issue These issues are a good way to get started with Clippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes issue 5095 xiongmao86/rust-clippy
[WIP] Fixes issue 5095 xiongmao86/rust-clippy
2 participants
@flip1995 @JohnTitor