unwrap_used lint fires for #[test]ing code

[jplatte]

It would be nice if there was a lint that fired on unwraps inside regular code, but not in #[test] (or #[cfg(test)]?) code, potentially just the existing unwrap_used lint.

• Do you think this is desireable as the default behaviour of unwrap_used or should it likely be a separate lint?
• Would this be hard to implement (i.e. how hard is it for clippy to tell whether some code is under #[test] / #[cfg(test)]?

[flip1995]

how hard is it for clippy to tell whether some code is under #[test] / #[cfg(test)]

We can only approximate this. We already doing this in the wildcard_imports lint. We approximate this by checking if we're currently inside a module called *test* (has the string test in its name).

The reason, we cannot check this is because when Clippy runs its lints the #[cfg(test)] attributes are already resolved by rustc and the code is either erased from the AST or it exists (without any attributes).

[flip1995]

We could make it configurable, so that it can be disabled in tests completely (with the heuristic described above)

[chansuke]

I'd like to work on this but my idea is that configure the method on top of fn check_fn() in clippy_lints/src/unwrap.rs.

[Firionus]

I think this can be closed since there now is #8802