Checking for (integer) constants in lints is inconsistent and does not handle all cases (e.g., static constants)

[mlegner]

Several lints such as the integer_arithmetic and modulo_one lint check for specific integer constants, typically +/-1, 0, MIN, MAX. However, this is currently implemented inconsistently, sometimes only checking for (+/-) literals (integer_arithmetic, see also #6209), sometimes also for constants (modulo_one). However, the modulo_one lint also fails to properly handle static constants (see also #6360); I am not sure, if this is due to some deeper reason I don't yet understand or if this is simply a bug.

I would suggest consolidating these checks for particular values to rely on a single constant-comparison function similar to (or replacing) the is_integer_const function, but also handling static constants. Likely, this could be used in other places as well.

[giraffate]

@rustbot modify labels: +L-enhancement

[c410-f3r]

arithmetic_side_effects does not suffer from this issue