Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpanlessHash should also hash patterns #7149

Closed
c410-f3r opened this issue May 1, 2021 · 0 comments · Fixed by #7157
Closed

SpanlessHash should also hash patterns #7149

c410-f3r opened this issue May 1, 2021 · 0 comments · Fixed by #7157
Assignees
@camsteffen

Comments

@c410-f3r
Copy link
Contributor

c410-f3r commented May 1, 2021

SpanlessHash currently only takes into consideration expressions but patterns should also be hashed.

rust-clippy/clippy_utils/src/hir_utils.rs

Line 716 in 841244d

// TODO: arm.pat?

@camsteffen camsteffen self-assigned this May 3, 2021
@camsteffen camsteffen mentioned this issue May 4, 2021
Merged
@bors bors closed this as completed in a8f28b6 May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camsteffen camsteffen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SpanlessHash add Pat camsteffen/rust-clippy
2 participants
@camsteffen @c410-f3r