panic lints for assert with formatting

[iliakonnov]

Lint name: panic

I tried this code:

#![warn(clippy::panic)]
fn main() {
    assert!(true, "True is not true!");
}

I expected to see this happen: No warning

Instead, this happened: panic should not be present in production code

For example, following code does not produce this warning:

#![warn(clippy::panic)]
fn main() {
    assert!(true);
}

I believe that behaviour should be the same, regardless of optional message existence. Both the warn on assert! and no warning will be reasonable, but the latter looks better for me.

This issue looks very similar to #7062.

Meta

• cargo clippy -V: clippy 0.1.55 (71b8742 2021-07-03)
• rustc -Vv:

  rustc 1.55.0-nightly (71b8742bb 2021-07-03)
  binary: rustc
  commit-hash: 71b8742bbcbed2cd908dbc031d6552d8b528c037
  commit-date: 2021-07-03
  host: x86_64-unknown-linux-gnu
  release: 1.55.0-nightly
  LLVM version: 12.0.1