Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Useless peekable iterator #854

Closed
mcarton opened this issue Apr 13, 2016 · 3 comments · Fixed by #9258
Closed

Useless peekable iterator #854

mcarton opened this issue Apr 13, 2016 · 3 comments · Fixed by #9258
Assignees
@Serial-ATA
Labels
A-lint Area: New lints E-medium Call for participation: Medium difficulty level problem and requires some initial experience.

Comments

@mcarton
Copy link
Member

mcarton commented Apr 13, 2016 •
edited by rustbot
Loading

Just noticed that when refactoring. We could warn when making an iterator peekable, but never actually peeking it(/returning it/passing it to a function).
@mcarton mcarton added E-medium Call for participation: Medium difficulty level problem and requires some initial experience. A-lint Area: New lints labels Apr 13, 2016
@birkenfeld
Copy link
Contributor

Sounds pretty specific. Are you sure it's worth it?

@Serial-ATA
Copy link
Contributor

@rustbot claim

@Serial-ATA Serial-ATA mentioned this issue Jul 29, 2022
Merged
@lukaslueg
Copy link
Contributor

@birkenfeld FWIW I've seen this in the wild, too

@bors bors closed this as completed in 2091142 Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Serial-ATA Serial-ATA

Labels
A-lint Area: New lints E-medium Call for participation: Medium difficulty level problem and requires some initial experience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add [unused_peekable] lint Serial-ATA/rust-clippy
4 participants
@birkenfeld @lukaslueg @mcarton @Serial-ATA