Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please move derive_partial_eq_without_eq to nursery #9530

Closed
jplatte opened this issue Sep 24, 2022 · 3 comments · Fixed by #9535
Closed

Please move derive_partial_eq_without_eq to nursery #9530

jplatte opened this issue Sep 24, 2022 · 3 comments · Fixed by #9535
Assignees
@alex-semenyuk

Comments

@jplatte
Copy link
Contributor

jplatte commented Sep 24, 2022 •
edited by rustbot
Loading

Description

There's still a large number of false positives with derive_partial_eq_without_eq, can you please move it to nursery?
@xFrednet
Copy link
Member

@rustbot claim

@alex-semenyuk alex-semenyuk mentioned this issue Sep 25, 2022
Merged
@xFrednet xFrednet mentioned this issue Sep 25, 2022
Closed
@alex-semenyuk
Copy link
Member

alex-semenyuk commented Sep 25, 2022 •
edited
Loading

@xFrednet oops, sorry forget to send claim:(

@xFrednet xFrednet assigned alex-semenyuk and unassigned xFrednet Sep 25, 2022
@xFrednet
Copy link
Member

No worries, now you're assigned to it 🙃

@bors bors closed this as completed in 00ebd8e Sep 25, 2022
mgeisler added a commit to mgeisler/textwrap that referenced this issue Oct 23, 2022
@mgeisler
Temporarily allow clippy::derive_partial_eq_without_eq
9fcce9b 
The lint has known false positives and has been moved to the nursery
on the nightly compiler:

  rust-lang/rust-clippy#9530

We’ll allow the lint for now until this change lands in a stable
compiler.
@mgeisler mgeisler mentioned this issue Oct 23, 2022
Merged
mgeisler added a commit to mgeisler/textwrap that referenced this issue Oct 23, 2022
@mgeisler
Derive Eq as well
3b38590 
This is from `clippy::derive_partial_eq_without_eq`. The lint has
known false positives and has been moved to the nursery on the nightly
compiler, though it seems okay in this case:

  rust-lang/rust-clippy#9530
@maksim1744 maksim1744 mentioned this issue Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-semenyuk alex-semenyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved derive_partial_eq_without_eq to nursery alex-semenyuk/rust-clippy
3 participants
@jplatte @alex-semenyuk @xFrednet