Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create clippy_config crate, hide internal representation from docs #11685

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

Alexendoo
Copy link
Member

r? @flip1995

The first commit moves a decent chunk of code out of clippy_lints/clippy_utils into a new crate clippy_config

The second commit changes how --explain, the book and the site render configuration values. The internal type is now hidden and the displayed defaults are now valid TOML values instead of Debug output

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 19, 2023
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly NITs.

.github/workflows/clippy_bors.yml Outdated Show resolved Hide resolved
clippy_lints/src/lib.rs Outdated Show resolved Hide resolved
tests/dogfood.rs Show resolved Hide resolved
tests/dogfood.rs Show resolved Hide resolved
@bors
Copy link
Contributor

bors commented Oct 21, 2023

☔ The latest upstream changes (presumably #11694) made this pull request unmergeable. Please resolve the merge conflicts.

@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 21, 2023
@Alexendoo Alexendoo force-pushed the clippy_config branch 3 times, most recently from 68a167f to 43d80a4 Compare October 21, 2023 14:43
@Alexendoo Alexendoo added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Oct 21, 2023
@bors
Copy link
Contributor

bors commented Oct 23, 2023

☔ The latest upstream changes (presumably #11699) made this pull request unmergeable. Please resolve the merge conflicts.

@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Oct 24, 2023

📌 Commit 436dd19 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 24, 2023

⌛ Testing commit 436dd19 with merge b25558b...

bors added a commit that referenced this pull request Oct 24, 2023
Create `clippy_config` crate, hide internal representation from docs

r? `@flip1995`

The first commit moves a decent chunk of code out of `clippy_lints`/`clippy_utils` into a new crate `clippy_config`

The second commit changes how `--explain`, the book and the site render configuration values. The internal type is now hidden and the displayed defaults are now valid TOML values instead of `Debug` output

changelog: none
@bors
Copy link
Contributor

bors commented Oct 24, 2023

💔 Test failed - checks-action_test

@Alexendoo
Copy link
Member Author

Needed an extern crate rustc_driver like the other crates

@bors r=flip1995

@bors
Copy link
Contributor

bors commented Oct 24, 2023

📌 Commit 7df1c8a has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 24, 2023

⌛ Testing commit 7df1c8a with merge 4eb4192...

@bors
Copy link
Contributor

bors commented Oct 24, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 4eb4192 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Oct 24, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 4eb4192 to master...

@bors bors merged commit 4eb4192 into rust-lang:master Oct 24, 2023
8 checks passed
@Alexendoo Alexendoo deleted the clippy_config branch October 24, 2023 12:49
bors added a commit that referenced this pull request Nov 6, 2023
update references of old `msrvs` and `conf` paths

In #11685, `clippy_lints::utils::conf` and `clippy_utils::msrvs` were moved to a separate `clippy_config` crate.
I noticed that not all references to those paths were updated, so this small PR intends to fix those.

changelog: none
fmease added a commit to fmease/rust that referenced this pull request Nov 8, 2023
…ertlarsan68

Document clippy_config in nightly-rustc docs

A new clippy crate added in rust-lang/rust-clippy#11685
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 8, 2023
…ertlarsan68

Document clippy_config in nightly-rustc docs

A new clippy crate added in rust-lang/rust-clippy#11685
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 8, 2023
Rollup merge of rust-lang#117667 - Alexendoo:doc-clippy-config, r=albertlarsan68

Document clippy_config in nightly-rustc docs

A new clippy crate added in rust-lang/rust-clippy#11685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants