Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rustc_semver with rustc_session::RustcVersion #13243

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Alexendoo
Copy link
Member

Allows dropping a dependency but there is a behaviour change here, the following versions are no longer accepted:

  • 1 (would need to be 1.0 or 1.0.0)
  • 1.0.0-alpha
  • 1.0.0-alpha.2
  • 1.0.0-beta

But this seems unlikely to effect anybody, I did some GitHub searching and found no occurrences outside our UI tests

r? @flip1995

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 9, 2024
@Jarcho
Copy link
Contributor

Jarcho commented Aug 9, 2024

Is there any reason for us to store the whole version? An MSRV of 1.30.1 would be the same as 1.30 for us since patch releases don't add new features. An MSRV of 2.0 or higher would mean we can't lint anything anyways since there's no guarantees that any of current rust works the same.

@Alexendoo
Copy link
Member Author

Mostly it's that storing the version as is makes the implementation simple, we could get away with just storing the minor version for the current MSRVs

It's not impossible that we'd want to gate some suggestion on a bugfix in the future though

@flip1995
Copy link
Member

RIP rustc-semver 🥲 I wrote this crate in the hope that Clippy, cargo and rustc can all use it. But then, everyone rolled their own implementation. So I think unifying Clippy version with the rustc implementation is a good idea.

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 12, 2024

📌 Commit b32a017 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 12, 2024

⌛ Testing commit b32a017 with merge 52192aa...

@bors
Copy link
Collaborator

bors commented Aug 12, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 52192aa to master...

@bors bors merged commit 52192aa into rust-lang:master Aug 12, 2024
8 checks passed
@Alexendoo Alexendoo deleted the rustcversion branch August 12, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants