Skip to content

Commit

Permalink
Don't die in try_unsafe_borrow if tls isn't ready
Browse files Browse the repository at this point in the history
If there's no TLS key just yet, then there's nothing to unsafely borrow, so
continue returning None. This prevents causing the runtime to abort itself when
logging before the runtime is fully initialized.

Closes #9487
  • Loading branch information
alexcrichton committed Sep 25, 2013
1 parent 7535479 commit 324418f
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 6 deletions.
16 changes: 10 additions & 6 deletions src/libstd/rt/local_ptr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,16 @@ pub unsafe fn unsafe_borrow<T>() -> *mut T {
}

pub unsafe fn try_unsafe_borrow<T>() -> Option<*mut T> {
let key = tls_key();
let void_ptr = tls::get(key);
if void_ptr.is_null() {
None
} else {
Some(void_ptr as *mut T)
match maybe_tls_key() {
Some(key) => {
let void_ptr = tls::get(key);
if void_ptr.is_null() {
None
} else {
Some(void_ptr as *mut T)
}
}
None => None
}
}

Expand Down
20 changes: 20 additions & 0 deletions src/test/run-pass/logging_before_rt_started.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// exec-env:RUST_LOG=std::ptr
// xfail-fast this would cause everything to print forever on windows...

// In issue #9487, it was realized that std::ptr was invoking the logging
// infrastructure, and when std::ptr was used during runtime initialization,
// this caused some serious problems. The problems have since been fixed, but
// this test will trigger "output during runtime initialization" to make sure
// that the bug isn't re-introduced.

fn main() {}

5 comments on commit 324418f

@bors
Copy link
Contributor

@bors bors commented on 324418f Sep 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from cmr
at alexcrichton@324418f

@bors
Copy link
Contributor

@bors bors commented on 324418f Sep 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging alexcrichton/rust/issue-9487 = 324418f into auto

@bors
Copy link
Contributor

@bors bors commented on 324418f Sep 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alexcrichton/rust/issue-9487 = 324418f merged ok, testing candidate = a268a1c

@bors
Copy link
Contributor

@bors bors commented on 324418f Sep 26, 2013

@bors
Copy link
Contributor

@bors bors commented on 324418f Sep 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = a268a1c

Please sign in to comment.