From 632aaa49278ad98a76b0f3d7e8b62dcd0de33e2b Mon Sep 17 00:00:00 2001 From: Anthony Ramine Date: Sun, 15 Apr 2018 13:38:00 +0200 Subject: [PATCH] Properly handle ranges of signed enums using both extremums (fixes #49973) --- src/librustc/ty/layout.rs | 11 ++++++----- src/test/run-pass/issue-49973.rs | 20 ++++++++++++++++++++ 2 files changed, 26 insertions(+), 5 deletions(-) create mode 100644 src/test/run-pass/issue-49973.rs diff --git a/src/librustc/ty/layout.rs b/src/librustc/ty/layout.rs index 5f9c305d92f04..208d61032861f 100644 --- a/src/librustc/ty/layout.rs +++ b/src/librustc/ty/layout.rs @@ -1677,18 +1677,19 @@ impl<'a, 'tcx> LayoutCx<'tcx, TyCtxt<'a, 'tcx, 'tcx>> { } } - let discr = Scalar { + let tag_mask = !0u128 >> (128 - ity.size().bits()); + let tag = Scalar { value: Int(ity, signed), - valid_range: (min as u128)..=(max as u128) + valid_range: (min as u128 & tag_mask)..=(max as u128 & tag_mask), }; - let abi = if discr.value.size(dl) == size { - Abi::Scalar(discr.clone()) + let abi = if tag.value.size(dl) == size { + Abi::Scalar(tag.clone()) } else { Abi::Aggregate { sized: true } }; tcx.intern_layout(LayoutDetails { variants: Variants::Tagged { - discr, + discr: tag, variants }, fields: FieldPlacement::Arbitrary { diff --git a/src/test/run-pass/issue-49973.rs b/src/test/run-pass/issue-49973.rs new file mode 100644 index 0000000000000..641e9239177fb --- /dev/null +++ b/src/test/run-pass/issue-49973.rs @@ -0,0 +1,20 @@ +// Copyright 2012 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#[derive(Debug)] +#[repr(i32)] +enum E { + Min = -2147483648i32, + _Max = 2147483647i32, +} + +fn main() { + assert_eq!(Some(E::Min).unwrap() as i32, -2147483648i32); +}