-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #51612 - ashtneoi:51515-missing-first-char, r=pnkfelix
NLL: fix E0594 "change to mutable ref" suggestion Fix #51515. Fix #51879. Questions: - [x] Is this the right place to fix this? It feels brittle, being so close to the frontend. **It's probably fine.** - [ ] Have I missed any other cases that trigger this behavior? - [x] Is it okay to use HELP and SUGGESTION in the UI test? **Yes.** - [x] Do I need more tests for this? **No.**
- Loading branch information
Showing
3 changed files
with
49 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
#![feature(nll)] | ||
|
||
fn main() { | ||
let foo = &16; | ||
//~^ HELP consider changing this to be a mutable reference | ||
//~| SUGGESTION &mut 16 | ||
*foo = 32; | ||
//~^ ERROR cannot assign to `*foo` which is behind a `&` reference | ||
let bar = foo; | ||
//~^ HELP consider changing this to be a mutable reference | ||
//~| SUGGESTION &mut i32 | ||
*bar = 64; | ||
//~^ ERROR cannot assign to `*bar` which is behind a `&` reference | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
error[E0594]: cannot assign to `*foo` which is behind a `&` reference | ||
--> $DIR/issue-51515.rs:17:5 | ||
| | ||
LL | let foo = &16; | ||
| --- help: consider changing this to be a mutable reference: `&mut 16` | ||
... | ||
LL | *foo = 32; | ||
| ^^^^^^^^^ `foo` is a `&` reference, so the data it refers to cannot be written | ||
|
||
error[E0594]: cannot assign to `*bar` which is behind a `&` reference | ||
--> $DIR/issue-51515.rs:22:5 | ||
| | ||
LL | let bar = foo; | ||
| --- help: consider changing this to be a mutable reference: `&mut i32` | ||
... | ||
LL | *bar = 64; | ||
| ^^^^^^^^^ `bar` is a `&` reference, so the data it refers to cannot be written | ||
|
||
error: aborting due to 2 previous errors | ||
|
||
For more information about this error, try `rustc --explain E0594`. |