Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing impl blocks when rustdoc inlines a type and -Zforce-unstable-if-unmarked is turned on #106421

Closed
notriddle opened this issue Jan 3, 2023 · 0 comments · Fixed by #121284
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@notriddle
Copy link
Contributor

Compare the following pages:

The issue can also be reproduced by setting up two crates, one with a type that has an inherent impl:

pub struct FatalError;
impl FatalError {
    pub fn raise(self) -> ! { loop {} }
}

And the other re-exports it:

pub use parent::FatalError;

And compile them with, specifically, the following CLI parameters:

RUSTFLAGS=-Zforce-unstable-if-unmarked cargo +dev doc

I expect raise to show up both in the original crate, and in the crate that re-exports it. Instead, it only shows blanket and auto trait impls.

@notriddle notriddle added C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 3, 2023
notriddle pushed a commit to notriddle/rust that referenced this issue Feb 19, 2024
Closes rust-lang#106421

This was already fixed by
f5d43a0, but now the test cases are
added.
notriddle added a commit to notriddle/rust that referenced this issue Feb 19, 2024
Closes rust-lang#106421

This was already fixed by
f5d43a0, but now the test cases are
added.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 24, 2024
…r=Mark-Simulacrum

Add test cases for inlining compiler-private items

Closes rust-lang#106421

This was already fixed by rust-lang#121218, but now the test cases are added.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 25, 2024
…r=Mark-Simulacrum

Add test cases for inlining compiler-private items

Closes rust-lang#106421

This was already fixed by rust-lang#121218, but now the test cases are added.
@bors bors closed this as completed in 24aa348 Feb 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 25, 2024
Rollup merge of rust-lang#121284 - notriddle:notriddle/issue-106421, r=Mark-Simulacrum

Add test cases for inlining compiler-private items

Closes rust-lang#106421

This was already fixed by rust-lang#121218, but now the test cases are added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
1 participant