Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use working debugger for debuginfo tests #109262

Open
Noratrieb opened this issue Mar 17, 2023 · 1 comment
Open

Use working debugger for debuginfo tests #109262

Noratrieb opened this issue Mar 17, 2023 · 1 comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Noratrieb
Copy link
Member

Currently, bootstrap/compiletest use a system debugger (like gdb or lldb) for debuginfo tests. People have very different setups and sometimes their system debugger simply doesn't work for the tests.

We shouldn't be using random system tools for the test suite unless we know that they work.

The debuginfo tests should just always download and use one that works. This needs some figuring out what the right one for that would be and where to get it from (do we have LLDB builds in our CI?).
@Noratrieb Noratrieb added A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 17, 2023
@jyn514 jyn514 added the A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself label Mar 17, 2023
@saethlin
Copy link
Member

Note that this is not just the case for broken debuggers (like the most recent gdb release) but also for debuggers with snazzy new features (such as a previous gdb release): #94458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@saethlin @jyn514 @Noratrieb