Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc-Json: Reexported items don't appear in paths #110007

Open
aDotInTheVoid opened this issue Apr 6, 2023 · 1 comment
Open

Rustdoc-Json: Reexported items don't appear in paths #110007

aDotInTheVoid opened this issue Apr 6, 2023 · 1 comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-has-mcve Status: A Minimal Complete and Verifiable Example has been found for this issue T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@aDotInTheVoid
Copy link
Member

#![feature(no_core)]
#![no_core]

mod bytes {
    pub struct Bytes;
}

pub use bytes::Bytes;
{
  "crate_version": null,
  "external_crates": {},
  "format_version": 24,
  "includes_private": false,
  "index": {
    "0:0:1024": {
      "crate_id": 0,
      "docs": null,
      "id": "0:0:1024",
      "inner": {"is_crate": true, "is_stripped": false, "items": ["0:4-0:2:1596"]},
      "kind": "module",
      "name": "path"
    },
    "0:2:1596": {
      "crate_id": 0,
      "docs": null,
      "id": "0:2:1596",
      "inner": {"generics": {"params": [], "where_predicates": []}, "impls": [], "kind": "unit"},
      "kind": "struct",
      "name": "Bytes"
    },
    "0:4-0:2:1596": {
      "crate_id": 0,
      "docs": null,
      "id": "0:4-0:2:1596",
      "inner": {"glob": false, "id": "0:2:1596", "name": "Bytes", "source": "bytes::Bytes"},
      "kind": "import",
      "name": null
    }
  },
  "paths": {"0:0:1024": {"crate_id": 0, "kind": "module", "path": ["path"]}},
  "root": "0:0:1024"
}

0:2:1596 should appear in paths

@aDotInTheVoid aDotInTheVoid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-json Area: Rustdoc JSON backend S-has-mcve Status: A Minimal Complete and Verifiable Example has been found for this issue labels Apr 6, 2023
@aDotInTheVoid
Copy link
Member Author

Bisected with

#!/bin/bash
set -eoxu pipefail
rustdoc -Z unstable-options -w json ./tests/rustdoc-json/path.rs
npath=$(jq '.paths | length' ./doc/path.json)
if [[ npath -ne "2" ]]
then
        exit 1
fi
searched toolchains nightly-2022-01-01 through nightly-2023-04-06


********************************************************************************
Regression in nightly-2022-07-17
********************************************************************************

fetching https://static.rust-lang.org/dist/2022-07-16/channel-rust-nightly-git-commit-hash.txt
nightly manifest 2022-07-16: 40 B / 40 B [===========================================================================================] 100.00 % 292.00 KB/s converted 2022-07-16 to 23e21bdd25026e2839ebe946c2a937c1904887d2
fetching https://static.rust-lang.org/dist/2022-07-17/channel-rust-nightly-git-commit-hash.txt
nightly manifest 2022-07-17: 40 B / 40 B [===========================================================================================] 100.00 % 425.59 KB/s converted 2022-07-17 to d5e7f4782e4b699728d0a08200ecd1a54d56a85d
looking for regression commit between 2022-07-16 and 2022-07-17
cloning rust repository
fetching (via local git) commits from 23e21bdd25026e2839ebe946c2a937c1904887d2 to d5e7f4782e4b699728d0a08200ecd1a54d56a85d
opening existing repository at "rust.git"
Found origin remote under name `origin`
refreshing repository at "rust.git"
looking up first commit
looking up second commit
checking that commits are by bors and thus have ci artifacts...
finding bors merge commits
found 7 bors merge commits in the specified range
  commit[0] 2022-07-15UTC: Auto merge of #99015 - lcnr:fn-ctxt-no-more, r=compiler-errors
  commit[1] 2022-07-15UTC: Auto merge of #99288 - Aaron1011:stable-intrinsics, r=yaahc
  commit[2] 2022-07-16UTC: Auto merge of #95685 - oxidecomputer:restore-static-dwarf, r=pnkfelix
  commit[3] 2022-07-16UTC: Auto merge of #96482 - willcrichton:fix-trait-suggestion-for-binops, r=estebank
  commit[4] 2022-07-16UTC: Auto merge of #99263 - compiler-errors:issue-99261, r=jyn514
  commit[5] 2022-07-16UTC: Auto merge of #99315 - JohnTitor:rollup-77wzoc1, r=JohnTitor
  commit[6] 2022-07-16UTC: Auto merge of #99346 - matthiaskrgr:rollup-p4dl1qt, r=matthiaskrgr
ERROR: no CI builds available between 23e21bdd25026e2839ebe946c2a937c1904887d2 and d5e7f4782e4b699728d0a08200ecd1a54d56a85d within last 167 days

#99346 includes #99287, and I bet that's it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-has-mcve Status: A Minimal Complete and Verifiable Example has been found for this issue T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

1 participant