Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symlinking is not working as expected on x build #110625

Closed
onur-ozkan opened this issue Apr 20, 2023 · 0 comments · Fixed by #110365
Closed

symlinking is not working as expected on x build #110625

onur-ozkan opened this issue Apr 20, 2023 · 0 comments · Fixed by #110365
Assignees
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@onur-ozkan
Copy link
Member

onur-ozkan commented Apr 20, 2023

Because of the early return here:

rust/src/bootstrap/compile.rs

Lines 1331 to 1335 in 3d7a091

return INTERNER.intern_path(sysroot);
}
// Symlink the source root into the same location inside the sysroot,
// where `rust-src` component would go (`$sysroot/lib/rustlib/src/rust`),

symlinking phases are bypassed which causes tools like miri can't find rust-src.

@onur-ozkan onur-ozkan added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Apr 20, 2023
@onur-ozkan onur-ozkan self-assigned this Apr 20, 2023
@onur-ozkan onur-ozkan changed the title symlinking is not working as expected after #104076 symlinking is not working as expected on x build Apr 20, 2023
@bors bors closed this as completed in f2321ec Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant