Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.toml generated by ./configure does not include tools= definition anymore #115502

Closed
dilyanpalauzov opened this issue Sep 3, 2023 · 0 comments · Fixed by #115530
Closed
Assignees
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@dilyanpalauzov
Copy link

I compile Rust by downloading it from https://forge.rust-lang.org/infra/other-installation-methods.html#source-code, unpacking, then calling

./configure --enable-optimize-llvm --enable-extended --llvm-root=/usr/local --enable-llvm-link-shared --enable-sanitizers --enable-local-rust

This generates a config.toml file. For Rust 1.72.0 the latter includes:

[build]
# Enable a build of the extended Rust tool set which is not only the compiler 
# but also tools such as Cargo. This will also produce "combined installers"
# which are used to install Rust and Cargo together. This is disabled by 
# default. The `tools` option (immediately below) specifies which tools should
# be built if `extended = true`. 
extended = true

The text above references “tools option (immediately below)”, but the file does not contain tools= definition. This is a regression towards Rust 1.65.0. With Rust 1.65.0 config.toml contained also

[build]
# Installs chosen set of extended tools if `extended = true`. By default builds
# all extended tools except `rust-demangler`, unless the target is also being
# built with `profiler = true`. If chosen tool failed to build the installation
# fails. If `extended = false`, this option is ignored.
tools = ["cargo", "rls", "clippy", "rustfmt", "analysis", "src"] # + "rust-demangler" if `profiler` 
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 3, 2023
@albertlarsan68 albertlarsan68 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 3, 2023
@Noratrieb Noratrieb added C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 4, 2023
@onur-ozkan onur-ozkan self-assigned this Sep 4, 2023
@bors bors closed this as completed in e39976f Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants