Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop enforcing FIXME issue numbers #11815

Closed
brson opened this issue Jan 26, 2014 · 6 comments
Closed

Stop enforcing FIXME issue numbers #11815

brson opened this issue Jan 26, 2014 · 6 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jan 26, 2014

Our tidy script doesn't allow FIXME to be written without a corresponding issue number. This has just led to us littering the codebase with XXX comments instead. Let's please just stop trying to enforce this policy.

cc #3303

This was referenced Jan 26, 2014
@salemtalha
Copy link
Contributor

Do you think, in the tidy script, we should warn if someone attempts to use XXX from here on out? With or without an issue number that is.

@brson
Copy link
Contributor Author

brson commented Jan 26, 2014

@salemtalha Yes, once they are all converted to FIXME, the tidy script should error when it sees XXX, similar to how it treats TODO.

@brson
Copy link
Contributor Author

brson commented Jan 26, 2014

I don't imagine this issue will be too controversial, but I'd like to hear other opinions.

@alexcrichton
Copy link
Member

Sounds reasonable to me, I don't think it matters so much as long as we canonicalize to one "fix this later" form, and FIXME is fine by me.

@huonw
Copy link
Member

huonw commented Jan 27, 2014

Fixed by #11817.

@huonw huonw closed this as completed Jan 27, 2014
@nikomatsakis
Copy link
Contributor

Hah. Not that I am going to resurrect this policy, but I've actually come to like our old FIXME policy, though I once railed against it. I've found it quite useful to be able to write // FIXME, secure in the knowledge that I will HAVE to address this problem before I am able to commit. Maybe we can add some similar string.

In other news, I now hate // NOTE despite advocating for it originally. It seems to be used exclusively to remind us (incessantly) that there is something that should be adjusted upon snapshot; usually though such cases are marked with #[cfg(stage0)] anyhow, and a comment that we can grep for when we do a snapshot would be sufficient.

bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
fix: rust-lang#12441 False-positive type-mismatch error with generic future

I think the reason is same with rust-lang#11815.
add ```Sized``` bound for ```AsyncBlockTypeImplTrait```.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

5 participants