-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop enforcing FIXME issue numbers #11815
Comments
Do you think, in the tidy script, we should warn if someone attempts to use XXX from here on out? With or without an issue number that is. |
@salemtalha Yes, once they are all converted to FIXME, the tidy script should error when it sees XXX, similar to how it treats TODO. |
I don't imagine this issue will be too controversial, but I'd like to hear other opinions. |
Sounds reasonable to me, I don't think it matters so much as long as we canonicalize to one "fix this later" form, and FIXME is fine by me. |
Fixed by #11817. |
Hah. Not that I am going to resurrect this policy, but I've actually come to like our old FIXME policy, though I once railed against it. I've found it quite useful to be able to write // FIXME, secure in the knowledge that I will HAVE to address this problem before I am able to commit. Maybe we can add some similar string. In other news, I now hate |
fix: rust-lang#12441 False-positive type-mismatch error with generic future I think the reason is same with rust-lang#11815. add ```Sized``` bound for ```AsyncBlockTypeImplTrait```.
Our tidy script doesn't allow FIXME to be written without a corresponding issue number. This has just led to us littering the codebase with XXX comments instead. Let's please just stop trying to enforce this policy.
cc #3303
The text was updated successfully, but these errors were encountered: