Emit a warning around thin &CStr
interior mutability breaks
#118513
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
From @chorman0773 https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/CStr.20as.20thin.20pointer/near/405432566
Passing an
&UnsafeCell<CStr>
tosize_of_val
is currently sound because it just returns the length parameter of the fat pointer. After makingCStr
thin however,size_of_val
will need to callstrlen
on the data. This is not ok in a&UnsafeCell
because another context could be writing the data, e.g. temporarily overwriting the\0
.This seems like something we may be able to emit a warning for?
Thin cstr: #59905
@rustbot label +T-libs +T-compiler +A-diagnostics
The text was updated successfully, but these errors were encountered: