Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: sccache has no effect / RUSTC_WRAPPER not used? #128633

Open
matthiaskrgr opened this issue Aug 4, 2024 · 2 comments
Open

bootstrap: sccache has no effect / RUSTC_WRAPPER not used? #128633

matthiaskrgr opened this issue Aug 4, 2024 · 2 comments
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@matthiaskrgr
Copy link
Member

b389b0a

It seems that when doing a x.py build or check, RUSTC_WRAPPER is no longer used, so all calls go directly to rustc and not sccache rustc which would allow caching through sccache?

When building rustc, I could see that the sccache was neither utilized (no cache hits) nor fed with new artifacts (no cache misses)

@matthiaskrgr matthiaskrgr added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Aug 4, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 4, 2024
@bjorn3
Copy link
Member

bjorn3 commented Aug 4, 2024

I am pretty sure that sccache will either not be effective (it doesn't cache when --sysroot is passed) or cause actual issues (like not invalidating the cache if the standard library gets changed) if it were to be used.

@matthiaskrgr
Copy link
Member Author

I'm wondering if #126476 is related. 🤔

@bjorn3 from just doing normal compiler bootstraps like x.py build/test/check I don't remember running into any frequent problems tbh 🤔

@workingjubilee workingjubilee changed the title bootstrap: sccache has on effect / RUSTC_WRAPPER not used? bootstrap: sccache has no effect / RUSTC_WRAPPER not used? Aug 4, 2024
@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

4 participants