Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run-make: vendor cargo dependencies or external dependencies within the tests #128733

Open
3 tasks
jieyouxu opened this issue Aug 6, 2024 · 1 comment
Open
3 tasks

run-make: vendor cargo dependencies or external dependencies within the tests #128733

jieyouxu opened this issue Aug 6, 2024 · 1 comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Aug 6, 2024 •
edited
Loading

  • tests/run-make/thumb-none-qemu
  • tests/run-make/x86_64-fortanix-unknown-sgx-lvi
  • tests/run-make/thumb-none-cortex-m (uses git clone too)

These tests use cargo to build crates but they have external dependencies -- this makes their pass/fail status conditioned on internet connectivity which does not seem ideal (and also if it's not pinned and it can become awkward from breakages..)

We should investigate if we could vendor the external deps or otherwise make them locally available to make the test outcomes more reproducible.
@jieyouxu jieyouxu added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-run-make Area: port run-make Makefiles to rmake.rs labels Aug 6, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 6, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 6, 2024
This was referenced Aug 6, 2024
Merged
Merged
@tdittr
Copy link
Contributor

tdittr commented Aug 7, 2024

For reference the this was discussed for thumb-none-qemu and thumb-none-cortex-m at an embedded WG meeting: rust-embedded/wg#783 (reply in thread)

@jieyouxu jieyouxu mentioned this issue Nov 7, 2024
Open
@jieyouxu jieyouxu added C-enhancement Category: An issue proposing an enhancement or a PR with one. and removed C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
Oxidizing run-make tests
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tdittr @jieyouxu @rustbot